fix(dashboard): properly handle recurring events #5486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5486 +/- ##
============================================
+ Coverage 22.59% 22.65% +0.05%
- Complexity 395 397 +2
============================================
Files 241 241
Lines 11854 11863 +9
Branches 2306 2306
============================================
+ Hits 2679 2687 +8
- Misses 9175 9176 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
fix/dashboard/properly-handle-recurrences
branch
from
c8f9829
to
babc444
Compare
st3iny
added
3. to review
|
/backport to stable4.5 |
backportbot-nextcloud
bot
added
the
backport-request
miaulalala
approved these changes
Sep 27, 2023
st3iny
added
4. to release
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dashboard will now correctly show and sort recurring events.
This also works without the server patch and will just hide outdated recurrences in this case. I think we should merge this asap to have proper event ordering.