Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): top right actions not positioned properly #5445

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Sep 4, 2023

Fix #5444

Backports are not needed as stable4.4 and stable3.5 are not affected.

Before After
Screenshot_20230904_113259 Screenshot_20230904_113204

@st3iny st3iny added this to the v4.5.0 milestone Sep 4, 2023
@st3iny st3iny self-assigned this Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (253a5ed) 22.68% compared to head (af4e4c1) 22.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5445   +/-   ##
=========================================
  Coverage     22.68%   22.68%           
  Complexity      387      387           
=========================================
  Files           240      240           
  Lines         11811    11811           
  Branches       2297     2297           
=========================================
  Hits           2679     2679           
  Misses         9132     9132           
Flag Coverage Δ
javascript 13.84% <ø> (ø)
php 64.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst ChristophWurst merged commit d0457a6 into main Sep 4, 2023
40 checks passed
@ChristophWurst ChristophWurst deleted the fix/editor/top-right-actions branch September 4, 2023 11:09
@ChristophWurst
Copy link
Member

Backports are not needed as stable4.4 and stable3.5 are not affected.

What about https://github.com/nextcloud/calendar/tree/stable4.5 tho?

@st3iny
Copy link
Member Author

st3iny commented Sep 4, 2023

/backport to stable4.5

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Sep 4, 2023
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Sep 4, 2023
@st3iny st3iny modified the milestones: v4.5.0, v4.6.0 Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple editor close button and actions positioned vertically, was horicontal
4 participants