Fix appointment booking loading #5410
Conversation
Signed-off-by: hamza221 <[email protected]>
hamza221
added
3. to review
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5410 +/- ##
============================================
- Coverage 22.66% 22.61% -0.05%
Complexity 372 372
============================================
Files 237 238 +1
Lines 11725 11749 +24
Branches 2282 2292 +10
============================================
Hits 2657 2657
- Misses 9068 9092 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| this.canClose = false | ||
| this.isLoading = true | ||
| try { | ||
| await this.$emit('save', { |
There was a problem hiding this comment.
so the issue was that event listeners are not awaitable?
|
cc @pjrobertson for testing and review :) |
|
Looking into it :) Still struggling to get a proper dev environment set up though. Is https://github.com/juliushaertl/nextcloud-docker-dev the best way to set up an environment? |
That's what I'm using and I can totally recommend it |
|
LGTM @ChristophWurst, I think it's good to merge! Also apologies, my PR didn't get it working correctly. |
|
@pjrobertson Thank you for the review |
hamza221
added
4. to release
closes #5409