Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(talk): Make event attendees Talk room participants #5380

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jul 27, 2023

Fixes #5376

Todo

  • Assign participants for new events
  • Add new participants for updates of existing events

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews enhancement New feature request labels Jul 27, 2023
@ChristophWurst ChristophWurst self-assigned this Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07% ⚠️

Comparison is base (12f5abd) 22.74% compared to head (847504c) 22.67%.
Report is 3 commits behind head on main.

❗ Current head 847504c differs from pull request most recent head 8820948. Consider uploading reports for the commit 8820948 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5380      +/-   ##
============================================
- Coverage     22.74%   22.67%   -0.07%     
  Complexity      372      372              
============================================
  Files           237      237              
  Lines         11684    11719      +35     
  Branches       2270     2278       +8     
============================================
  Hits           2657     2657              
- Misses         9027     9062      +35     
Flag Coverage Δ
javascript 13.90% <0.00%> (-0.06%) ⬇️
php 65.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/services/talkService.js 0.00% <0.00%> (ø)
src/store/calendarObjectInstance.js 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 27, 2023
@ChristophWurst ChristophWurst marked this pull request as draft July 27, 2023 14:10
@ChristophWurst
Copy link
Member Author

Works! Ready for review

@ChristophWurst ChristophWurst marked this pull request as ready for review August 2, 2023 17:59
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 2, 2023
src/services/talkService.js Outdated Show resolved Hide resolved
@ChristophWurst ChristophWurst force-pushed the feat/talk/attendees-to-participants branch from 847504c to 8820948 Compare August 4, 2023 12:46
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 4, 2023
@ChristophWurst ChristophWurst merged commit c394097 into main Aug 4, 2023
38 of 40 checks passed
@ChristophWurst ChristophWurst deleted the feat/talk/attendees-to-participants branch August 4, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign attendees as Talk room participants when creating a room from an event
2 participants