fix(TreeMapper#isFolderSharedWithUser): Check full depth

Signed-off-by: Marcel Klehr <[email protected]>
nextcloud · Sep 20, 2024 · 3ae6a9d · 3ae6a9d
1 parent 93e8743
commit 3ae6a9d
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/lib/Db/TreeMapper.php b/lib/Db/TreeMapper.php
@@ -1151,14 +1151,18 @@ public function isFolderSharedWithUser(int $folderId, string $userId): bool {
 			// noop
 		}
 
-		$ancestors = $this->findParentsOf(TreeMapper::TYPE_FOLDER, $folderId);// FIXME: This will not find ancestors
-		foreach ($ancestors as $ancestorFolder) {
-			try {
-				$this->sharedFolderMapper->findByFolderAndUser($ancestorFolder->getId(), $userId);
-				return true;
-			} catch (DoesNotExistException) {
-				// noop
+		try {
+			while ($ancestorFolder = $this->findParentOf(TreeMapper::TYPE_FOLDER, $folderId)) {
+				try {
+					$this->sharedFolderMapper->findByFolderAndUser($ancestorFolder->getId(), $userId);
+					return true;
+				} catch (DoesNotExistException) {
+					// noop
+				}
+				$folderId = $ancestorFolder->getId();
 			}
+		} catch (DoesNotExistException $e) {
+			// noop
 		}
 
 		return false;