Login Textfield Design #7971

AndyScherzinger · 2021-02-11T11:58:25Z

Using container-style for text fields (initially just for the login screen since it has a specific set of colors)

Also:

for testing updated notes dialog to native view binding
move login activity to native view binding

Screenshots (German)

Empty with hint	Focused	With Text

Sidenote

I am aware that there is also a design issue with the QR code part but that should go into a separate PR since it is not related to the changes needed for the text field.
The overall styling is "Material Standard" so we only changed the colors (as in "use white color"), all semi-transparencies, text sizes etc. are material's defaults.

Testing

Tests written, or not not needed

Signed-off-by: Andy Scherzinger <[email protected]>

AndyScherzinger · 2021-02-11T11:58:56Z

Waiting for the screenshot tests to update them accordingly...

tobiasKaminsky

Great job!

* utilize endIcon capabilities * move to native view binding Signed-off-by: Andy Scherzinger <[email protected]>

AndyScherzinger · 2021-02-11T14:09:38Z

more screenshots for @jancborchardt

1	2	3	4

jancborchardt · 2021-02-11T15:42:46Z

@AndyScherzinger thanks! Yeah, those warnings are there too – I would say it’s fine if below that warning container we have another block of text (which also shows when the warning is not there of course) saying:

The link to your Nextcloud web interface when you open it in the browser.

This can be in a bit subdued text, like 70% opacity white. We use that wording for the new desktop client flow as well: nextcloud/desktop#2895 (comment)

Signed-off-by: Andy Scherzinger <[email protected]>

AndyScherzinger · 2021-02-11T17:03:49Z

@jancborchardt see screenshots below. I put the error container below because there could actually be 2 lines so that would come with a large blue-space™️

Also "Nextcloud" is a placeholder, so the app name is brand-able like in other places throughout the client 👍

1	2	3

codecov · 2021-02-11T17:18:24Z

Codecov Report

Merging #7971 (a2d31e8) into master (65300c3) will decrease coverage by 0.04%.
The diff coverage is 38.20%.

@@             Coverage Diff              @@
##             master    #7971      +/-   ##
============================================
- Coverage     29.27%   29.22%   -0.05%     
  Complexity        5        5              
============================================
  Files           443      443              
  Lines         34800    34804       +4     
  Branches       4809     4811       +2     
============================================
- Hits          10187    10172      -15     
- Misses        23076    23106      +30     
+ Partials       1537     1526      -11

Impacted Files	Coverage Δ	Complexity Δ
...om/owncloud/android/ui/activity/EditorWebView.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...owncloud/android/ui/dialog/NoteDialogFragment.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
.../android/authentication/AuthenticatorActivity.java	`37.74% <43.03%> (-0.24%)`	`0.00 <0.00> (ø)`
.../java/com/nextcloud/client/jobs/OfflineSyncWork.kt	`9.25% <0.00%> (-9.26%)`	`0.00% <0.00%> (ø%)`
.../third_parties/daveKoeller/AlphanumComparator.java	`79.76% <0.00%> (-2.39%)`	`0.00% <0.00%> (ø%)`
.../owncloud/android/files/services/FileUploader.java	`52.74% <0.00%> (-2.25%)`	`0.00% <0.00%> (ø%)`
...va/com/owncloud/android/utils/FilesSyncHelper.java	`21.33% <0.00%> (-1.34%)`	`0.00% <0.00%> (ø%)`
...loud/android/datamodel/ThumbnailsCacheManager.java	`37.45% <0.00%> (-1.26%)`	`0.00% <0.00%> (ø%)`
...rc/main/java/com/owncloud/android/db/OCUpload.java	`52.44% <0.00%> (-0.70%)`	`0.00% <0.00%> (ø%)`
...owncloud/android/ui/adapter/OCFileListAdapter.java	`39.25% <0.00%> (-0.66%)`	`0.00% <0.00%> (ø%)`
... and 5 more

jancborchardt · 2021-02-11T17:27:33Z

Noice @AndyScherzinger! Only design adjustment would be to make sure the text is flush left with the "Server address" field label and content, as well as having some more line-height, like so:

Signed-off-by: Andy Scherzinger <[email protected]>

* utilize endIcon capabilities * move to native view binding Signed-off-by: Andy Scherzinger <[email protected]>

AndyScherzinger · 2021-02-11T17:44:06Z

@jancborchardt alignment fixed and line-multiplier=1.2 added 👍

1	2	3

Signed-off-by: Andy Scherzinger <[email protected]>

nextcloud-android-bot · 2021-02-11T18:00:58Z

Blue-Dark-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7971-Screenshot-Blue-Dark-17-49

…ip ci] Signed-off-by: drone <noreply@drone>

nextcloud-android-bot · 2021-02-11T22:33:08Z

Blue-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7971-Screenshot-Blue-Light-22-21

nextcloud-android-bot · 2021-02-12T00:48:31Z

Blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7971-Screenshot-Blue-Light-20-15

Signed-off-by: Andy Scherzinger <[email protected]>

nextcloud-android-bot · 2021-02-12T09:30:40Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/7971.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

nextcloud-android-bot · 2021-02-12T09:55:18Z

Codacy

Lint

Type	master	PR
Warnings	243	240
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	52
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	73
Security Warnings	41
Dodgy code Warnings	99
Total	310

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	52
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	73
Security Warnings	41
Dodgy code Warnings	99
Total	310

nextcloud-android-bot · 2021-02-12T09:57:51Z

White-Dark-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

nextcloud-android-bot · 2021-02-12T10:09:34Z

White-Dark-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7971-Screenshot-White-Dark-09-57

jancborchardt

Looks great design-wise, nice work @AndyScherzinger! :)

nextcloud-android-bot · 2021-02-12T10:23:43Z

White-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

nextcloud-android-bot · 2021-02-12T10:35:27Z

White-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7971-Screenshot-White-Light-10-23

nextcloud-android-bot · 2021-02-12T14:15:07Z

Blue-Dark-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7971-Screenshot-Blue-Dark-09-44

move note dialog to native view binding

1a8434d

Signed-off-by: Andy Scherzinger <[email protected]>

AndyScherzinger added design 2. developing labels Feb 11, 2021

AndyScherzinger force-pushed the textfieldDesign branch from 84639c5 to cbec728 Compare February 11, 2021 12:27

nextcloud deleted a comment from nextcloud-android-bot Feb 11, 2021

tobiasKaminsky approved these changes Feb 11, 2021

View reviewed changes

AndyScherzinger force-pushed the textfieldDesign branch from cbec728 to b95c66d Compare February 11, 2021 12:44

nextcloud deleted a comment from nextcloud-android-bot Feb 11, 2021

user container-styling for text field on login screen

c8144a0

* utilize endIcon capabilities * move to native view binding Signed-off-by: Andy Scherzinger <[email protected]>

AndyScherzinger force-pushed the textfieldDesign branch from b95c66d to c8144a0 Compare February 11, 2021 12:55

AndyScherzinger added 3. to review and removed 2. developing labels Feb 11, 2021

AndyScherzinger added this to the Nextcloud App 3.16.0 milestone Feb 11, 2021

add helper text to server address field

0dad484

Signed-off-by: Andy Scherzinger <[email protected]>

AndyScherzinger force-pushed the textfieldDesign branch from bfd66ae to 0dad484 Compare February 11, 2021 16:56

AndyScherzinger added 2 commits February 11, 2021 18:27

spotbugs: remove unused paramter and add null-check where needed

c7a8062

Signed-off-by: Andy Scherzinger <[email protected]>

user container-styling for text field on login screen

d863131

* utilize endIcon capabilities * move to native view binding Signed-off-by: Andy Scherzinger <[email protected]>

AndyScherzinger force-pushed the textfieldDesign branch from 205653a to d863131 Compare February 11, 2021 17:38

Add some more whitespace below the input field

d776035

Signed-off-by: Andy Scherzinger <[email protected]>

Drone: update Lint results to reflect reduced error/warning count [sk…

a2d31e8

…ip ci] Signed-off-by: drone <noreply@drone>

hardening of passcode screenshot test

e21f6ef

Signed-off-by: Andy Scherzinger <[email protected]>

jancborchardt approved these changes Feb 12, 2021

View reviewed changes

AndyScherzinger merged commit b760abd into master Feb 12, 2021

delete-merged-branch bot deleted the textfieldDesign branch February 12, 2021 11:04

AndyScherzinger changed the title ~~Textfield design~~ Login Textfield designt Feb 15, 2021

AndyScherzinger changed the title ~~Login Textfield designt~~ Login Textfield design Feb 15, 2021

AndyScherzinger changed the title ~~Login Textfield design~~ Login Textfield Design Feb 15, 2021

AndyScherzinger mentioned this pull request Feb 15, 2021

Login Textfield design nextcloud/talk-android#1010

Merged

AndyScherzinger mentioned this pull request Apr 9, 2021

Backport/enhance login screen nextcloud/talk-android#1115

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Login Textfield Design #7971

Login Textfield Design #7971

AndyScherzinger commented Feb 11, 2021 •

edited

Loading

AndyScherzinger commented Feb 11, 2021

tobiasKaminsky left a comment

AndyScherzinger commented Feb 11, 2021

jancborchardt commented Feb 11, 2021

AndyScherzinger commented Feb 11, 2021 •

edited

Loading

codecov bot commented Feb 11, 2021 •

edited

Loading

jancborchardt commented Feb 11, 2021

AndyScherzinger commented Feb 11, 2021 •

edited

Loading

nextcloud-android-bot commented Feb 11, 2021

nextcloud-android-bot commented Feb 11, 2021

nextcloud-android-bot commented Feb 12, 2021

nextcloud-android-bot commented Feb 12, 2021

nextcloud-android-bot commented Feb 12, 2021

nextcloud-android-bot commented Feb 12, 2021

nextcloud-android-bot commented Feb 12, 2021

jancborchardt left a comment

nextcloud-android-bot commented Feb 12, 2021

nextcloud-android-bot commented Feb 12, 2021

nextcloud-android-bot commented Feb 12, 2021

Login Textfield Design #7971

Login Textfield Design #7971

Conversation

AndyScherzinger commented Feb 11, 2021 • edited Loading

Screenshots (German)

Sidenote

Testing

AndyScherzinger commented Feb 11, 2021

tobiasKaminsky left a comment

Choose a reason for hiding this comment

AndyScherzinger commented Feb 11, 2021

jancborchardt commented Feb 11, 2021

AndyScherzinger commented Feb 11, 2021 • edited Loading

codecov bot commented Feb 11, 2021 • edited Loading

Codecov Report

jancborchardt commented Feb 11, 2021

AndyScherzinger commented Feb 11, 2021 • edited Loading

nextcloud-android-bot commented Feb 11, 2021

nextcloud-android-bot commented Feb 11, 2021

nextcloud-android-bot commented Feb 12, 2021

nextcloud-android-bot commented Feb 12, 2021

nextcloud-android-bot commented Feb 12, 2021

Codacy

Lint

SpotBugs (new)

SpotBugs (master)

nextcloud-android-bot commented Feb 12, 2021

nextcloud-android-bot commented Feb 12, 2021

jancborchardt left a comment

Choose a reason for hiding this comment

nextcloud-android-bot commented Feb 12, 2021

nextcloud-android-bot commented Feb 12, 2021

nextcloud-android-bot commented Feb 12, 2021

AndyScherzinger commented Feb 11, 2021 •

edited

Loading

AndyScherzinger commented Feb 11, 2021 •

edited

Loading

codecov bot commented Feb 11, 2021 •

edited

Loading

AndyScherzinger commented Feb 11, 2021 •

edited

Loading