refactor(ui): coroutine based user status retrieval. #13927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* | ||
| * Nextcloud - Android Client | ||
| * | ||
| * SPDX-FileCopyrightText: 2024 Your Name <[email protected]> |
There was a problem hiding this comment.
You might want to update this line from the template ;)
|
Hi @ardevd - long time no see 😃 PR looks good to me, just one minor thing regarding the template license header, else 👍 |
|
@AndyScherzinger glad to see you're still around :) Fixed the license header now, I think. |
Replaced ancient async task with a coroutine based alternative. This comes with numerous advantages. - Improved performance due to the nature of coroutines and the reduced overhead associated with AsyncTasks and threads. Approx a %50 performance increase was measured during testing. - Passing references to fragment lifecycle context to an AsyncTask is generally a bad idea.
ardevd
force-pushed
the
replace-status-async-task
branch
from
0dbbc68
to
ffc0528
Compare
AndyScherzinger
approved these changes
Nov 1, 2024
|
Yes I am - Also happy to keep being around while I don't have much time these days for coding work :/ |
tobiasKaminsky
approved these changes
Nov 4, 2024
|
Welcome back 🎉 Can you check "spotlessKotlinCheck" and "Codacy"? There is something to do. Rest is false positive. |
alperozturk96
approved these changes
Nov 4, 2024
codacy Signed-off-by: tobiasKaminsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced ancient async task with a coroutine based alternative. This comes with numerous advantages.