Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReceiveExternalFilesActivity intent #12406

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

ZetaTom
Copy link
Collaborator

@ZetaTom ZetaTom commented Jan 23, 2024

This change fixes a crash when the app was presented with a specially crafted intent.

Intents to share files with Nextcloud via ReceiveExternalFilesActivity.java are now checked, if they contain the appropriate actions and extras before attempting to parse them.

If an intent lacks the appropriate action or extras, an error message is displayed.

  • Tests written, or not not needed

@ZetaTom ZetaTom force-pushed the fix/externalfiles-intent branch 2 times, most recently from 71bfdc0 to 7c6668c Compare February 5, 2024 09:31
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12406.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6868
Correctness7171
Dodgy code351351
Experimental22
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5656
Security1919
Total582582

Copy link

@tobiasKaminsky tobiasKaminsky merged commit 4e2a472 into master Mar 15, 2024
17 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/externalfiles-intent branch March 15, 2024 13:52
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.29.0 milestone Mar 16, 2024
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants