Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcTimeZonePicker): scope css styles #6184

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 31, 2024

☑️ Resolves

  • Fix leaking styles to all NcSelects

Not sure, if left rule should be applied, see it's broken on master, but at least scoped to timezone:

Current Expected
image image

🖼️ Screenshots

<template>
	<span>
		<NcDateTimePicker
			v-model="time"
			type="datetime"
			:show-timezone-select="true"
			:timezone-id.sync="tz" /><br>
		{{ time }} | {{ tz }}
		<br>
		<NcSelect v-model="tz"/>
	</span>
</template>
🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added 3. to review Waiting for reviews feature: datepicker Related to the date/time picker component regression Regression of a previous working feature labels Oct 31, 2024
@Antreesy Antreesy added this to the 8.20.0 milestone Oct 31, 2024
@Antreesy Antreesy self-assigned this Oct 31, 2024
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Antreesy
Copy link
Contributor Author

Antreesy commented Nov 5, 2024

/backport to next

@Antreesy Antreesy merged commit 2492acf into master Nov 5, 2024
19 checks passed
@Antreesy Antreesy deleted the fix/6095/scope-date-picker branch November 5, 2024 09:20
@ShGKme ShGKme changed the title fix: scope css styles for TimeZonePicker fix(NcTimeZonePicker): scope css styles Nov 5, 2024
@Antreesy Antreesy added the bug Something isn't working label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: datepicker Related to the date/time picker component regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants