Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reference-picker): allow closing modal dialog on NcReferencePicker #6137

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix(reference-picker): allow closing modal dialog on NcReferencePicker #6137

merged 1 commit into from
Oct 17, 2024

Conversation

JuliaKirschenheuter
Copy link
Contributor

☑️ Resolves

Fix possibility to close dialog via Esc if focus stays on "close" button

🖼️ Screenshots

🏚️ Before

Peek 2024-10-10 12-51

🏡 After

Peek 2024-10-10 12-49

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Oct 10, 2024
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Oct 10, 2024
@ShGKme ShGKme added bug Something isn't working feature: smart picker labels Oct 10, 2024
@ShGKme ShGKme added this to the 8.19.1 milestone Oct 10, 2024
@ShGKme ShGKme changed the title fix(files): allow closing modal dialog on RichText picker modal fix(reference-picker): allow closing modal dialog on NcReferencePicker Oct 10, 2024
Antreesy
Antreesy approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Talk, doesn't seem to break anything for us

@juliusknorr juliusknorr merged commit f2c75d5 into master Oct 17, 2024
19 checks passed
@juliusknorr juliusknorr deleted the fix/4328-Pressing-Esc-key-on-Link-picker-dialog-closes-the-document branch October 17, 2024 06:59
@juliusknorr
Copy link
Contributor

/backport to next

@backportbot backportbot bot mentioned this pull request Oct 17, 2024
Merged
@Antreesy Antreesy mentioned this pull request Oct 29, 2024
Open
@Antreesy Antreesy modified the milestones: 8.19.1, 8.20.0 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@susnux susnux Awaiting requested review from susnux

@ShGKme ShGKme Awaiting requested review from ShGKme

@elzody elzody Awaiting requested review from elzody

@enjeck enjeck Awaiting requested review from enjeck

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews bug Something isn't working feature: smart picker
Projects
None yet
Milestone
8.20.0
Development

Successfully merging this pull request may close these issues.

Pressing Esc key on Link picker dialog closes the document
4 participants
@JuliaKirschenheuter @juliusknorr @Antreesy @ShGKme