Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcRichText): show links title for desktop client #6127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Oct 2, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@DorraJaouad DorraJaouad added 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Oct 2, 2024
@DorraJaouad DorraJaouad added this to the 8.19.1 milestone Oct 2, 2024
@DorraJaouad DorraJaouad requested review from ShGKme and Antreesy October 2, 2024 06:55
@DorraJaouad DorraJaouad self-assigned this Oct 2, 2024
@DorraJaouad DorraJaouad marked this pull request as ready for review October 2, 2024 07:09
@Antreesy
Copy link
Contributor

Antreesy commented Oct 2, 2024

Should we do it all the time (without props)? Or if href doesn't match content?

@ShGKme
Copy link
Contributor

ShGKme commented Oct 3, 2024

Should we do it all the time (without props)? Or if href doesn't match content?

Then it duplicates already existing web-browser feature

@ShGKme ShGKme added the enhancement New feature or request label Oct 3, 2024
@ShGKme ShGKme modified the milestones: 8.19.1, 8.20.0 Oct 3, 2024
@DorraJaouad
Copy link
Contributor Author

Or if href doesn't match content?

I say we keep the same for all links

@Antreesy
Copy link
Contributor

Antreesy commented Oct 7, 2024

Then it duplicates already existing web-browser feature

True. I couldn't find any related options or preferences in Electron app, but that anyway should be done in talk-desktop repo, I believe. Another point of doing that is that we have links outside of NcRichText (as conversation links, settings redirects)

Maybe we can implement it with a custom solution, like:

  • add listener on hover
  • if it's a link, draw a preview box in the corner

@Antreesy Antreesy modified the milestones: 8.20.0, 8.21.0 Nov 11, 2024
@Antreesy Antreesy modified the milestones: 8.21.0, 8.22.0 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: richtext Related to the richtext component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hovering a markdown link with the mouse should give an indication which page will be opened
3 participants