-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcDateTimePicker): change styling to look more like the native picker #6095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Very big improvement when we compare it to the current design :)
- Is it possible to hide the first row in this case? The topmost week that is shown should be the week containing the 1st of the month (eg. we are on September but the last week of August is also shown)
- Is it possible to hide the double arrows which skip to the same month next year (
«
and»
) since I imagine that functionality is not used very often. This would also provide more horizontal space for the month name :) - As @susnux mentioned the size should be a variable (
--clickable-area-small
should work here) - Nice-to-have: Show full month name
Unfortunately, i cannot find a way, but i removed the background color, so it doesnt look too crowded. The rest is done. I updated to screenshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh thanks for testing it, @nimishavijay i guess we need the buttons :D |
Please also have a look at #6125. I missed that you were also working on the date picker design 🙈 |
we can merge them, no problem, the change is the same, with small difference, like the hover button state. Do you want to include mine at yours, or should i add yours here? |
Signed-off-by: greta <[email protected]>
de40c8a
to
dedbceb
Compare
/backport to next |
☑️ Resolves
🖼️ Screenshots
🏚️ Before | 🏡 After
after
🚧 Tasks
🏁 Checklist
next
requested with a Vue 3 upgrade