Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcListItem): make the max width in oneline mode apply only to the content name #6039

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix(NcListItem): make the max width in oneline mode apply only to the content name #6039

merged 1 commit into from
Sep 3, 2024

Conversation

GVodyanov
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2024-09-02 16-30-31 Screenshot from 2024-09-02 16-31-48

@GVodyanov
fix(NcListItem): make the max width of the NcListItem in oneline mode…
dbb6f50 
… apply only to the content name

Signed-off-by: Grigory Vodyanov <[email protected]>
@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Sep 2, 2024
@GVodyanov GVodyanov self-assigned this Sep 2, 2024
susnux
susnux approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me for the one line design 👍

GretaD
GretaD approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tested it by adding the values on web console and not linking :) #sorry

@GretaD GretaD merged commit 6f7b554 into master Sep 3, 2024
19 checks passed
@GretaD GretaD deleted the fix/list-item-one-line-width branch September 3, 2024 11:45
@susnux susnux added the bug Something isn't working label Sep 3, 2024
@susnux susnux added this to the 8.18.0 milestone Sep 3, 2024
@susnux
Copy link
Contributor

susnux commented Sep 3, 2024

Please remember to set the labels correctly they are needed for changelog generation (bug, enhancement, refactor) :)

@susnux
Copy link
Contributor

susnux commented Sep 3, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Sep 3, 2024
Merged
@ShGKme ShGKme changed the title NcListItem: make the max width of the NcListItem in oneline mode apply only to the content name fix(NcListItem) make the max width in oneline mode apply only to the content name Sep 5, 2024
@ShGKme ShGKme changed the title fix(NcListItem) make the max width in oneline mode apply only to the content name fix(NcListItem): make the max width in oneline mode apply only to the content name Sep 5, 2024
This was referenced Sep 12, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@susnux susnux susnux approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@GVodyanov GVodyanov

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
8.18.0
Development

Successfully merging this pull request may close these issues.

List view layout only uses the left part of the screen
3 participants
@GVodyanov @susnux @GretaD