Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NcAppSidebar): correctly define and document exposed CSS variables #5861

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jul 24, 2024

☑️ Resolves

  • Although AppSidebar's and AppNavigation's toggle button paddings have the same value, they don't have a single source
  • Replaced using navigation SCSS variable in the sidebar with the direct value
  • Fixed docs for --app-sidebar-offset
  • Added "Exposed CSS Variables" docs section

🖼️ Screenshots

image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Jul 24, 2024
@ShGKme ShGKme added this to the 8.15.1 milestone Jul 24, 2024
@ShGKme ShGKme requested review from susnux, Pytal and Antreesy July 24, 2024 12:09
@ShGKme ShGKme self-assigned this Jul 24, 2024
@susnux
Copy link
Contributor

susnux commented Jul 24, 2024

Thank you this is a very nice thing :)

@ShGKme ShGKme force-pushed the chore/nc-app-sidebar--do-not-use-nc-app-navigation-vars branch from 01b3b29 to 38a9884 Compare July 24, 2024 12:18
@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 24, 2024

Force pushed just a commit message typo fix

@susnux
Copy link
Contributor

susnux commented Jul 24, 2024

@ShGKme you need to update cypress snapshots 🙈

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 24, 2024

@ShGKme you need to update cypress snapshots 🙈

I changed nothing 🥲

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 24, 2024

Will do so later today

@susnux
Copy link
Contributor

susnux commented Jul 24, 2024

I changed nothing 🥲

Maybe a padding or something else moved like 1px?

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 24, 2024

Ok, actually, it is relevant. Variables are defined on an element outside the AppSidebar which doesn't work for Cypress.

@susnux
Copy link
Contributor

susnux commented Jul 24, 2024

Ok, actually, it is relevant. Variables are defined on an element outside the AppSidebar which doesn't work for Cypress.

Put it into NcContent in the cypress tests? For the PlayWright migration this was done 😅

@ShGKme ShGKme force-pushed the chore/nc-app-sidebar--do-not-use-nc-app-navigation-vars branch from 840c422 to 77b2f6f Compare July 25, 2024 07:47
@susnux susnux modified the milestones: 8.15.1, 8.15.2 Jul 29, 2024
@ShGKme ShGKme modified the milestones: 8.15.2, 8.16.0 Aug 3, 2024
@Antreesy Antreesy removed this from the 8.16.0 milestone Aug 5, 2024
@Antreesy Antreesy added this to the 8.17.0 milestone Aug 5, 2024
@susnux susnux removed this from the 8.17.0 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants