[next] fix(NcModal): temporary deactivate focus-traps on modal open #5852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
added
bug
susnux
force-pushed
the
backport/5783/next
branch
from
7c5d5f3
to
453f125
Compare
susnux
approved these changes
Jul 22, 2024
Antreesy
reviewed
Jul 22, 2024
susnux
reviewed
Jul 22, 2024
Comment on lines
12
to
30
| <div class="navigation__header"> | ||
| <NcTextField :value.sync="searchValue" label="Search …" /> | ||
| <NcActions> | ||
| <NcActionButton close-after-click @click="showModal = true"> | ||
| <template #icon> | ||
| <IconCog /> | ||
| </template> | ||
| App settings (close after click) | ||
| </NcActionButton> | ||
| <NcActionButton @click="showModal = true"> | ||
| <template #icon> | ||
| <IconCog /> | ||
| </template> | ||
| App settings (handle only click) | ||
| </NcActionButton> | ||
| </NcActions> | ||
| </div> |
There was a problem hiding this comment.
@Antreesy when you handle the .sync could you also rephrase this part to not have something like search? Because search should only be handled by NcAppNavigationSearch and we should not have examples doing it other
There was a problem hiding this comment.
- [next] feat(NcAppNavigation): Provide consistent in-app search #5848 is not backported yet
Don't you mind, if I forward-port it as-is, then replace this example on master and then push to the next afterwards?
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
backport/5783/next
branch
from
453f125
to
965fc87
Compare
Antreesy
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #5783