Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NcUserStatusIcon): remove warn if status is not set #5715

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 17, 2024

☑️ Resolves

  • Removes a warning error from server
  • This could also be fixed on server side by using v-if on component node.
    But actually, this component already has v-if="activeStatus" on root and works completely normal without status being set.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added 3. to review Waiting for reviews technical debt labels Jun 17, 2024
@ShGKme ShGKme added this to the 8.13.0 milestone Jun 17, 2024
@ShGKme ShGKme requested review from susnux and Pytal June 17, 2024 11:38
@ShGKme ShGKme self-assigned this Jun 17, 2024
@susnux susnux merged commit 47aebdc into master Jun 20, 2024
19 checks passed
@susnux susnux deleted the chore/NcUserStatusIcon--remove-warn branch June 20, 2024 09:25
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 20, 2024

/backport to next

Copy link

backportbot bot commented Jun 20, 2024

The backport to next failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout next
git pull origin next

# Create the new backport branch
git checkout -b backport/5715/next

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5b2304dc

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5715/next

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux
Copy link
Contributor

susnux commented Jun 20, 2024

/backport to next

Copy link

backportbot bot commented Jun 20, 2024

The backport to next failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout next
git pull origin next

# Create the new backport branch
git checkout -b backport/5715/next

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5b2304dc

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5715/next

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants