Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add isDarkTheme functions and composables #5698
feat: add isDarkTheme functions and composables #5698
Changes from all commits
9c51326
8dc23cf
5eba1f1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work, just do not import with
.ts
extension in Typescript files (in JS files it work).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, I missed that styleguidist uses a different config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have 46 places with
.ts
imports in this repoThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as long as it is in JavaScript files and not Typescript.
Importing with
.ts
extension in Typescript is invalid when emitting is enabled, as the output will be invalid.So as long as we use a bundler everything works, but e.g.
tsc
would not work, because Typescript does not rewrite import extensions, so you either have to import Typescript files with.js
or without any extension.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We almost never use
tsc
as a compiler (exceptnotify_push
) and in general, in modern TypeScript usage it's rarely used as a compiler/language and not as a static analyzer (type checker).Specifically, in this repo, we already had
@babel/typescript-preset
to work with TS as a static analyzer, and only the webpack config was not correct.This file was deleted.