fix(NcAppSidebar): restore attrs and classes inheritance #5688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Makes
<NcAppSIdebar>
withFragment
work like there is noFragment
open
state to prevent focus trap issues on mobile #5584<Fragment>
breaks:attributes
andclasses
, because in Vue 2 they are not a part of$attrs
and even cannot be defined as$props
data-v-{scopeid}
on the root elementv-show
but it is not fixed in this PR<Transition>
does not pass attributes with disabled inheritance (no idea why, but in vue 2 this component was not so pure)This PR restores it in quite a dirty way. I don't see any better solution without a breaking change.
Example of broken apps -
Files
:cy-data-sidebar
attributes fore2e
app-sidebar--full
classdata-v-{scopeId}
attr required forapp-sidebar--full
🖼️ Screenshots
🚧 Tasks
attrs
andlisteners
on<aside>
directlydata-v-{scopeid}
from$parent
🏁 Checklist
next
requested with a Vue 3 upgrade