chore(directives): add docs #5665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
3. to review
susnux
reviewed
Jun 7, 2024
|
|
||
| Tooltip directive based on [v-tooltip](https://github.com/Akryum/v-tooltip). | ||
|
|
||
| Note: it's preferred to use [native HTML title attribute](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title) instead for accessibility. |
There was a problem hiding this comment.
I dunno, to be honest ⚆_⚆
In theory - yes, because we migrated everywhere in nextcloud-vue already to title. But apps are still using it also because of visual result.
Maybe we should re-check this rule.
There was a problem hiding this comment.
But we can do it after merging docs for already created and not yet marked deprecated directives 👀
|
Rebased onto |
Signed-off-by: Grigorii K. Shartsev <[email protected]>
|
Fixed SPDX comments in new files |
Antreesy
approved these changes
Jun 14, 2024
| content: 'docs/directives/focus.md', | ||
| }, | ||
| { | ||
| name: 'Linkify', |
There was a problem hiding this comment.
I'd love to see component documentations in separate files as well, to keep SFC clean, but something for later maybe
There was a problem hiding this comment.
Or at least move it to the end of the file, not the top 🥲
|
/backport to next |
2 tasks
4 tasks
This was referenced Aug 9, 2024
This was referenced Aug 19, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
New docs
Directives usage
Focus
Linkify
🚧 Tasks