Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] fix(NcAppSidebar): remove hidden navigation toggle from focus trap #5616

Merged
merged 1 commit into from
May 19, 2024
Merged

[next] fix(NcAppSidebar): remove hidden navigation toggle from focus trap #5616

merged 1 commit into from
May 19, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented May 19, 2024

Backport of PR #5613

@backportbot backportbot bot requested review from susnux, szaimen and ShGKme May 19, 2024 12:32
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature feature: app-sidebar Related to the app-sidebar component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels May 19, 2024
@ShGKme
Copy link
Contributor

ShGKme commented May 19, 2024

@susnux
Copy link
Contributor

susnux commented May 19, 2024

It should be merged after #5615, but not conflicts

You already merged it?

@ShGKme
Copy link
Contributor

ShGKme commented May 19, 2024

You already merged it?

not on the second I posted this comment, waiting for CI :D

@ShGKme ShGKme merged commit d71d620 into next May 19, 2024
17 checks passed
@ShGKme ShGKme deleted the backport/5613/next branch May 19, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux susnux approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: app-sidebar Related to the app-sidebar component regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShGKme @susnux