Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppNavigation): restore hiding toggle on mobile #5603

Merged
merged 1 commit into from
May 17, 2024
Merged

fix(NcAppNavigation): restore hiding toggle on mobile #5603

merged 1 commit into from
May 17, 2024

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 17, 2024 •
edited
Loading

Follow-up to #2747

Before After
image image

@szaimen szaimen added bug Something isn't working 2. developing Work in progress regression Regression of a previous working feature design Design, UX, interface and interaction design 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 17, 2024
@szaimen szaimen marked this pull request as ready for review May 17, 2024 08:56
@szaimen szaimen requested a review from Antreesy May 17, 2024 09:52
Antreesy
Antreesy approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susnux susnux merged commit 2a6c03d into master May 17, 2024
19 checks passed
@susnux susnux deleted the enh/noid/hide-toggle branch May 17, 2024 11:16
@susnux susnux mentioned this pull request May 17, 2024
Merged
@ShGKme ShGKme mentioned this pull request May 17, 2024
Merged
4 tasks
@susnux
Copy link
Contributor

susnux commented May 19, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request May 19, 2024
Merged
@ShGKme ShGKme changed the title feat(mobile): restore hiding the appnavigation on mobile fix(NcAppNavigation): restore hiding toggle on mobile May 19, 2024
@susnux susnux mentioned this pull request Jul 3, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@susnux susnux susnux approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szaimen @susnux @Antreesy