fix: Adjust Typescript definition export #5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
susnux
commented
May 11, 2024
| @@ -39,22 +39,27 @@ | |||
| "require": "./dist/index.cjs" | |||
| }, | |||
| "./dist/Components/*.js": { | |||
| "types": "./dist/components/*/index.d.ts", | |||
| "import": "./dist/Components/*.mjs", | |||
There was a problem hiding this comment.
I would be so happy to get rid of the uppercase path...
susnux
commented
May 11, 2024
| @@ -607,7 +607,7 @@ export default defineComponent({ | |||
| }, | |||
|
|
|||
| ncPopoverTriggerAttrs() { | |||
| return this.getNcPopoverTriggerAttrs() | |||
| return (this.getNcPopoverTriggerAttrs as () => Record<string, string|undefined>)() | |||
There was a problem hiding this comment.
When using Options API it is always infered as unknown only Composition API (setup) will provide correct type information without any need to cast it here.
susnux
commented
May 11, 2024
| @@ -3,5 +3,5 @@ | |||
| "compilerOptions": { | |||
| "rootDir": ".." | |||
| }, | |||
| "include": ["./**/*.ts"], | |||
There was a problem hiding this comment.
we only need to reset the excludes from the root config
Make sure Typescript definitions are correctly exported. Also export them from the package. Signed-off-by: Ferdinand Thiessen <[email protected]>
ShGKme
approved these changes
May 13, 2024
Comment on lines
-107
to
+116
| libraryFormats: ['es', 'cjs'], | ||
| libraryFormats: ['cjs', 'es'], |
There was a problem hiding this comment.
Make sure Typescript definitions are emitted for ESM output (overwrites the CJS)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Make sure Typescript definitions are correctly exported. Also export them from the package.
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade