[next] fix: Adjust tsconfig and eslintrc for tests #5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes `rootdir` in invalid place in tsconfig. * Fixes wrong location of eslintrc Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
bug
ShGKme
reviewed
May 10, 2024
| @@ -12,11 +12,13 @@ | |||
| "strict": true, | |||
| "noImplicitAny": false, | |||
| "outDir": "./dist", | |||
| "rootDir": "./src", | |||
There was a problem hiding this comment.
Maybe make it just the root to keep structure?
Suggested change
| "rootDir": "./src", | |
| "rootDir": ".", |
There was a problem hiding this comment.
The the output will be dist/src/... instead of dist/...
And would also include files in the output that are only for development.
So setting root to our sources only.
ShGKme
changed the title
Yes only on next this is an issue |
ShGKme
approved these changes
May 10, 2024
Antreesy
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
rootdirin invalid place in tsconfig.🏁 Checklist