feat(NcAppNavigationCaption): Add heading-id prop to allow setting the ID on the caption itself
#5565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
ShGKme
reviewed
May 8, 2024
src/components/NcAppNavigationCaption/NcAppNavigationCaption.vue
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
susnux
force-pushed
the
fix/navigation-caption
branch
from
a4b6522
to
302fa7b
Compare
susnux
added
enhancement
susnux
changed the title
caption-id prop to allow setting the ID on the caption itself
ShGKme
approved these changes
May 10, 2024
ShGKme
reviewed
May 10, 2024
src/components/NcAppNavigationCaption/NcAppNavigationCaption.vue
Outdated
Show resolved
Hide resolved
susnux
force-pushed
the
fix/navigation-caption
branch
from
302fa7b
to
8ab5fcd
Compare
…the ID on the caption itself Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/navigation-caption
branch
from
8ab5fcd
to
5d4b6d7
Compare
susnux
changed the title
caption-id prop to allow setting the ID on the caption itselfheading-id prop to allow setting the ID on the caption itself
Antreesy
approved these changes
May 10, 2024
|
/backport to next |
|
The backport to # Switch to the target branch and update it
git checkout next
git pull origin next
# Create the new backport branch
git checkout -b backport/5565/next
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5d4b6d70
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5565/nextError: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Did it manually: #5580 |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Add a prop to set caption id to the caption, needed for linking list and caption.
🏁 Checklist
nextrequested with a Vue 3 upgrade