fix(NcReferenceWidget): use requestAnimationFrame in observers #5561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without `requestAnimationFrame` resize observer causes cypress to crash. Also use a ref for the width and a computed for the resulting number of lines. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/request-animation-frame-for-observers
branch
from
f795563
to
440b5a7
Compare
|
Cypress fails like this:
No idea what is causing this. |
ShGKme
approved these changes
May 7, 2024
ShGKme
reviewed
May 7, 2024
susnux
approved these changes
May 7, 2024
juliusknorr
approved these changes
May 7, 2024
Signed-off-by: Max <[email protected]>
Seems more light weight and also fixes the cypress tests Also add comments as to why we are using nextTick in the resizeObserver. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/request-animation-frame-for-observers
branch
from
9738fe4
to
112eee7
Compare
|
/backport to next |
This was referenced May 11, 2024
Merged
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
requestAnimationFrameresize observer causes cypress to crash.Also use a ref for the width and a computed for the resulting number of lines.
☑️ Resolves
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade