[next] chore(master): merge master into next
#5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n colors Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
If the type is set to number and a number is passed as value also emit a number instead of a string. Co-authored-by: Grigorii K. Shartsev <[email protected]> Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
…pport-numeric-value enh(NcInputField): Support numeric values - if numeric also emit numeric
Bumps [@nextcloud/webpack-vue-config](https://github.com/nextcloud/webpack-vue-config) from `fa79b40` to `84bc123`. - [Release notes](https://github.com/nextcloud/webpack-vue-config/releases) - [Commits](nextcloud-libraries/webpack-vue-config@fa79b40...84bc123) --- updated-dependencies: - dependency-name: "@nextcloud/webpack-vue-config" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
…yarn/nextcloud/webpack-vue-config-84bc123
Signed-off-by: Raimund Schlüßler <[email protected]>
…progress feat(NcProgressBar): add circular progress bar
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
100% translated source file: 'l10n/messages.pot' on 'es'.
…9836fb49eeb7494eb2c87d1dac Updates for project Nextcloud vue library
Signed-off-by: julia.kirschenheuter <[email protected]>
…accessible-opacity Remove inaccessible opacity from SettingsSection
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
…ithub-markdown feat(`NcRichText`) add support of GFM (extended markdown)
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
chore(release): v8.5.0
100% translated source file: 'l10n/messages.pot' on 'cs_CZ'.
…9836fb49eeb7494eb2c87d1dac
100% translated source file: 'l10n/messages.pot' on 'tr'.
…9836fb49eeb7494eb2c87d1dac Updates for project Nextcloud vue library
raimund-schluessler
added
3. to review
raimund-schluessler
force-pushed
the
chore/noid/merge-master-next
branch
from
5ae106a
to
3b391e9
Compare
raimund-schluessler
requested review from
susnux,
Pytal,
ShGKme,
Antreesy and
emoral435
susnux
approved these changes
Jan 23, 2024
|
Ah, I had a prepared backport at my laptop for you 🙈 |
Antreesy
approved these changes
Jan 24, 2024
Comment on lines
+589
to
+590
| // Vue 2.7 renders three non-breaking spaces here for some reason | ||
| expect(item).have.text(' ' + testCases[index].output) |
There was a problem hiding this comment.
Suggested change
| // Vue 2.7 renders three non-breaking spaces here for some reason | |
| expect(item).have.text(' ' + testCases[index].output) | |
| expect(item).have.text(testCases[index].output) |
This test fails for me at least locally
There was a problem hiding this comment.
Probably, should be contains
There was a problem hiding this comment.
Weird, the test seems to run fine on CI, no?
There was a problem hiding this comment.
Seems to run fine, as we see it. But I believe, Grigorii's proposal should fit here better
There was a problem hiding this comment.
I also have this issue on master locally.
There was a problem hiding this comment.
I also have this issue on master locally.
Thanks for taking care of it on master
ShGKme
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
masterintonext.This was one hell of a backport 🙈 But I think I got everything working. And it also fixes the search box of
NcEmojiPickerthat currently does not work fornext.After this is merged, I want an alpha release of
nextcloud/[email protected]😉