Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cypress from 9.7.0 to 12.3.0 #3609

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 4, 2023

Bumps cypress from 9.7.0 to 12.3.0.

Release notes

Sourced from cypress's releases.

v12.3.0

Changelog: https://docs.cypress.io/guides/references/changelog#12-3-0

v12.2.0

Changelog: https://docs.cypress.io/guides/references/changelog#12-2-0

v12.1.0

Changelog: https://docs.cypress.io/guides/references/changelog#12-1-0

v12.0.2

Changelog: https://docs.cypress.io/guides/references/changelog#12-0-2

v12.0.1

Changelog: https://docs.cypress.io/guides/references/changelog#12-0-1

v12.0.0

Changelog: https://docs.cypress.io/guides/references/changelog#12-0-0

v11.2.0

Changelog: https://docs.cypress.io/guides/references/changelog#11-2-0

v11.1.0

Changelog: https://docs.cypress.io/guides/references/changelog#11-1-0

v11.0.1

Changelog: https://docs.cypress.io/guides/references/changelog#11-0-1

v11.0.0

Changelog: https://docs.cypress.io/guides/references/changelog#11-0-0

v10.11.0

Changelog: https://docs.cypress.io/guides/references/changelog#10-11-0

v10.10.0

Changelog: https://docs.cypress.io/guides/references/changelog#10-10-0

v10.9.0

Changelog: https://docs.cypress.io/guides/references/changelog#10-9-0

v10.8.0

Changelog: https://docs.cypress.io/guides/references/changelog#10-8-0

v10.7.0

Changelog: https://docs.cypress.io/guides/references/changelog#10-7-0

v10.6.0

Changelog: https://docs.cypress.io/guides/references/changelog#10-6-0

v10.5.0

Changelog: https://docs.cypress.io/guides/references/changelog#10-5-0

... (truncated)

Commits
  • d0ba032 chore: bump to 12.3.0 [skip ci] (#25355)
  • 5f536fe fix: make NODE_ENV "production" for prod builds of launchpad (#25320)
  • 05b9f10 fix: .contains() should only return one element at all times (#25250)
  • acc61d8 feat: add currentRetry to Cypress API (#25297)
  • 736c599 chore: release @​cypress/webpack-dev-server-v3.2.2
  • f20c6f5 chore: release create-cypress-tests-v2.0.1
  • c12a7e3 fix: change wording for spec creation (#25271)
  • 3925ae0 fix: truncate text to fix layout (#25270)
  • 7cbd2c5 chore: release @​cypress/webpack-preprocessor-v5.16.1
  • 6fc13e6 fix: added missing pending data which caused incorrect mochaawesome reports (...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Jan 4, 2023
@skjnldsv skjnldsv force-pushed the dependabot/npm_and_yarn/cypress-12.3.0 branch 6 times, most recently from d000dca to 0681ccf Compare January 6, 2023 11:20
@raimund-schluessler
Copy link
Contributor

raimund-schluessler commented Jan 6, 2023

@susnux Did a migration to cypress 11.2.0 in #3565 but using vite and vue3. I don't know if any of his changes could be of use here.

@skjnldsv
Copy link
Contributor

skjnldsv commented Jan 6, 2023

@raimund-schluessler well, I'd like to keep things separated.
If we migrate and fix cypress before vue3, this will simplify the migration and reviewing #3565 greatly

@raimund-schluessler
Copy link
Contributor

@raimund-schluessler well, I'd like to keep things separated. If we migrate and fix cypress before vue3, this will simplify the migration and reviewing #3565 greatly

I agree. I am just not sure if that's feasible 🙈

@skjnldsv skjnldsv force-pushed the dependabot/npm_and_yarn/cypress-12.3.0 branch from 0681ccf to 71c65a3 Compare January 6, 2023 13:05
@skjnldsv
Copy link
Contributor

skjnldsv commented Jan 6, 2023

I agree. I am just not sure if that's feasible see_no_evil

Well, migrating to vue 3 should barely touch cypress. As only the livrary used @cypress/vue2 changes as well as the cypress config devServer section.
In any case, let's try to move forward I'd say. i'll help rebase #3565

@skjnldsv skjnldsv force-pushed the dependabot/npm_and_yarn/cypress-12.3.0 branch 3 times, most recently from db98f8c to 674710a Compare January 6, 2023 13:32
dependabot bot and others added 2 commits January 6, 2023 14:39
Bumps [cypress](https://github.com/cypress-io/cypress) from 9.7.0 to 12.3.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md)
- [Commits](cypress-io/cypress@v9.7.0...v12.3.0)

---
updated-dependencies:
- dependency-name: cypress
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv force-pushed the dependabot/npm_and_yarn/cypress-12.3.0 branch from 674710a to b3ea3f5 Compare January 6, 2023 13:39
@skjnldsv
Copy link
Contributor

skjnldsv commented Jan 6, 2023

Seems the pictures got a bit wider. That's odd

Before:
NcAppSidebar vue-subtitle_null-starred_false-compact_true-header_image-secondary_button-editable_false-base (1)
After:
NcAppSidebar vue-subtitle_null-starred_false-compact_true-header_image-secondary_button-editable_false-base

EDIT: the images are now 500px wide, which is actually normal for the sidebar as it expand up to $sidebar-max-width
https://github.com/nextcloud/nextcloud-vue/blob/e822b5114891bf1fffaedb2c32168cb6433af26f/src/components/NcAppSidebar/NcAppSidebar.vue#L613
https://github.com/nextcloud/nextcloud-vue/blob/e822b5114891bf1fffaedb2c32168cb6433af26f/src/components/NcAppSidebar/NcAppSidebar.vue#L641

The real question is why was it 300px before! 😁

@raimund-schluessler ready to review

@raimund-schluessler
Copy link
Contributor

Seems the pictures got a bit wider. That's odd

Maybe the viewportWidth/Height was not or is not respected. But if it's only this, I think we can live with it.

@skjnldsv
Copy link
Contributor

skjnldsv commented Jan 6, 2023

@skjnldsv skjnldsv added 3. to review Waiting for reviews technical debt and removed 3. to review Waiting for reviews labels Jan 6, 2023
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@skjnldsv skjnldsv merged commit ef6cd55 into master Jan 6, 2023
@skjnldsv skjnldsv deleted the dependabot/npm_and_yarn/cypress-12.3.0 branch January 6, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews dependencies Pull requests that update a dependency file technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants