fix(css-plugin): Use generateBundle
hook to prevent CSS imports from being lost
#112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NcRichContenteditable
: @mention item is not rendered properly in other apps nextcloud-vue#4901We must use
generateBundle
as Vite removes "empty css chunks" (chunks that only import css) in itsgenerateBundle
hook and merged theimportedCss
property down to the really emitted chunks.Otherwise we will loose CSS imports!
See this example of the NcMentionBubble on the comments tab, current master with 8.5.1 the "after" with 8.5.1 but compiled with this changes.