Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcDialog): Make the heading always center aligned on top #965

Merged
merged 2 commits into from
Aug 28, 2023
Merged

fix(NcDialog): Make the heading always center aligned on top #965

merged 2 commits into from
Aug 28, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 28, 2023

As discussed the heading should always be on top and center aligned.

full size mid small
Screenshot_20230828_113421 Screenshot_20230828_113416 Screenshot_20230828_113416

@susnux susnux mentioned this pull request Aug 27, 2023
Open
15 tasks
@susnux susnux mentioned this pull request Aug 28, 2023
Merged
szaimen
szaimen approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@susnux susnux merged commit 012057b into master Aug 28, 2023
8 checks passed
@susnux susnux deleted the fix/dialog-name branch August 28, 2023 18:35
@skjnldsv skjnldsv mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @szaimen