-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update twitter icon #12091
base: main
Are you sure you want to change the base?
fix: update twitter icon #12091
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@sarthak-kumar-shailendra is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
0e14df6
to
89e8f62
Compare
@balazsorban44 Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't directly tag the maintainers 🙏
Good catch though, thanks!
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 30 30" width="480px" height="480px"><path d="M26.37,26l-8.795-12.822l0.015,0.012L25.52,4h-2.65l-6.46,7.48L11.28,4H4.33l8.211,11.971L12.54,15.97L3.88,26h2.65 l7.182-8.322L19.42,26H26.37z M10.23,6l12.34,18h-2.1L8.12,6H10.23z"/></svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, can you remove the hard coded height/width and additional extra space before 'viewBox'? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should create a new X provider instead, and mark twitter as deprecated.
☕️ Reasoning
The Twitter logo has been changed and hasn't been updated on the site. [Fixes #12090]
After changes
🧢 Checklist
🎫 Affected issues
📌 Resources