Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): Add Loops Email Provider and Documentation #11197

Open
wants to merge 57 commits into
base: main
Choose a base branch
from

Conversation

Whats-A-MattR
Copy link

☕️ Reasoning

Email / Magic Token Auth is great.
Loops.so make a great product for Email that goes beyond just transactional emails, I use them as my provider and love the platform.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes: This Feature Request

📌 Resources

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 3:09am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 3:09am

Copy link

vercel bot commented Jun 18, 2024

@Whats-A-MattR is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@Whats-A-MattR Whats-A-MattR changed the title Add Loopa.so as Email Provider Add Loops.so as Email Provider Jun 18, 2024
@Whats-A-MattR Whats-A-MattR changed the title Add Loops.so as Email Provider Add Loops.so Email Provider and Documentation Jun 18, 2024
@github-actions github-actions bot added providers core Refers to `@auth/core` labels Jun 18, 2024
@Whats-A-MattR Whats-A-MattR marked this pull request as ready for review June 18, 2024 06:40
@Whats-A-MattR Whats-A-MattR changed the title Add Loops.so Email Provider and Documentation Add Loops Email Provider and Documentation Jun 18, 2024
@Whats-A-MattR Whats-A-MattR changed the title Add Loops Email Provider and Documentation Feat(providers): Add Loops Email Provider and Documentation Jun 18, 2024
@Whats-A-MattR
Copy link
Author

Pls approve.

@ndom91
Copy link
Member

ndom91 commented Sep 22, 2024

Ah so after fixing some of the other build issues in the repo, it looks like there's still an issue with this PR / loops provider, see: https://github.com/nextauthjs/next-auth/actions/runs/10983054627/job/30492001767?pr=11197

@Whats-A-MattR
Copy link
Author

Whats-A-MattR commented Sep 23, 2024

@ndom91

Ah so after fixing some of the other build issues in the repo, it looks like there's still an issue with this PR / loops provider, see: https://github.com/nextauthjs/next-auth/actions/runs/10983054627/job/30492001767?pr=11197

yeah, I had implemented different types for Loops but you removed them in this commit

I've now resolved and build is working again - at least locally...

@Whats-A-MattR
Copy link
Author

How about we get some merge happening @ndom91 @ThangHuuVu @ubbe-xyz
Should all be ready to go

@Whats-A-MattR
Copy link
Author

How about we get some merge happening @ndom91 @ThangHuuVu @ubbe-xyz Should all be ready to go

bumping again

@Whats-A-MattR
Copy link
Author

updating from base (again).

@Whats-A-MattR
Copy link
Author

@ndom91 @ThangHuuVu @ubbe-xyz could we possibly do the thing now please?

@ndom91
Copy link
Member

ndom91 commented Oct 28, 2024

@ndom91 @ThangHuuVu @ubbe-xyz could we possibly do the thing now please?

Please don't tag maintainers directly 🙏

Regarding getting this in, are the extra types you added back really necessary? Look at how simple the other email providers are for example.

@Whats-A-MattR
Copy link
Author

@ndom91 @ThangHuuVu @ubbe-xyz could we possibly do the thing now please?

Please don't tag maintainers directly 🙏

Regarding getting this in, are the extra types you added back really necessary? Look at how simple the other email providers are for example.

To include the transactionalId without the LSP complaining, type errors being thrown, and the build and test scripts failing I had to do the typing.

The other providers are unaffected as all I did was type the props of a function in the interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants