-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(providers): Add Loops Email Provider and Documentation #11197
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@Whats-A-MattR is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Pls approve. |
Ah so after fixing some of the other build issues in the repo, it looks like there's still an issue with this PR / loops provider, see: https://github.com/nextauthjs/next-auth/actions/runs/10983054627/job/30492001767?pr=11197 |
yeah, I had implemented different types for Loops but you removed them in this commit I've now resolved and build is working again - at least locally... |
How about we get some merge happening @ndom91 @ThangHuuVu @ubbe-xyz |
bumping again |
updating from base (again). |
@ndom91 @ThangHuuVu @ubbe-xyz could we possibly do the thing now please? |
Please don't tag maintainers directly 🙏 Regarding getting this in, are the extra types you added back really necessary? Look at how simple the other email providers are for example. |
To include the transactionalId without the LSP complaining, type errors being thrown, and the build and test scripts failing I had to do the typing. The other providers are unaffected as all I did was type the props of a function in the interface. |
☕️ Reasoning
Email / Magic Token Auth is great.
Loops.so make a great product for Email that goes beyond just transactional emails, I use them as my provider and love the platform.
🧢 Checklist
🎫 Affected issues
Fixes: This Feature Request
📌 Resources