Optimize video tag

next-theme · Oct 21, 2020 · afb052c · afb052c · stevenjoezhang · Jan 9, 2021
1 parent 6a64215
commit afb052c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/scripts/tags/video.js b/scripts/tags/video.js
@@ -5,5 +5,5 @@
 'use strict';
 
 module.exports = function(args) {
-  return `<video src="${args}" preload="metadata" controls playsinline poster="">Sorry, your browser does not support the video tag.</video>`;
+  return `<video src="${args[0]}" preload="metadata" controlslist="nodownload" controls playsinline poster="${args[1] || ''}"></video>`;
 };
diff --git a/test/tags/video.js b/test/tags/video.js
@@ -6,6 +6,10 @@ describe('video', () => {
   const postVideo = require('../../scripts/tags/video');
 
   it('default', () => {
-    postVideo(['https://example.com/sample.mp4']).should.eql('<video src="https://example.com/sample.mp4" preload="metadata" controls playsinline poster="">Sorry, your browser does not support the video tag.</video>');
+    postVideo(['https://example.com/sample.mp4']).should.eql('<video src="https://example.com/sample.mp4" preload="metadata" controlslist="nodownload" controls playsinline poster=""></video>');
+  });
+
+  it('poster', () => {
+    postVideo(['https://example.com/sample.mp4', 'https://example.com/sample.jpg']).should.eql('<video src="https://example.com/sample.mp4" preload="metadata" controlslist="nodownload" controls playsinline poster="https://example.com/sample.jpg"></video>');
   });
 });