-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
step3: 로또(2등) 구현 #948
Open
kdh85
wants to merge
13
commits into
next-step:kdh85
Choose a base branch
from
kdh85:step3
base: kdh85
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
step3: 로또(2등) 구현 #948
Commits on Nov 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8190087 - Browse repository at this point
Copy the full SHA 8190087View commit details
Commits on Nov 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6897ca8 - Browse repository at this point
Copy the full SHA 6897ca8View commit details -
* 로또와 보너스번호로 구성된 당첨로또 객체를 정의함. * 로또의 번호 일치수와 보너스번호 일치여부를 통해서 해당 로또의 당첨순위를 반환하는 책임을 가짐.
Configuration menu - View commit details
-
Copy full SHA for ae8dcd7 - Browse repository at this point
Copy the full SHA ae8dcd7View commit details -
* 기존에 Record를 생성해서 반환하는 책임을 제거. * 2등 보너스 등급을 추가. * 등급별 일치하는 수와 보너스카운트 여부를 받아서 등급을 반환하는 책임 추가.
Configuration menu - View commit details
-
Copy full SHA for a97f954 - Browse repository at this point
Copy the full SHA a97f954View commit details -
step3: 로또(2등) 등급별당첨결 및 등급별당첨 일큽콜랙션 객체 구현
* 기존에 Record, LotteryReuslt의 책임을 재설계한 신규 등급관련 클래스를 정의함. * 등급랭크와 랭크별 수량을 다루는 책임을 가지는 LottoRecord클래스를 구현. * 등급랭크의 수량을 1씩 증가시키는 책임을 가짐. * LottoRecord의 일급콜랙션 LottoRecords를 구현함. * 기존 LotteryResult가 가지고 있던 당첨통계에 대한 책임을 그대로 이관함. * 기존에 로또번들과 당첨로또를 주입해서 결과를 계산하던 부분을 계산결과를 받아 통계를 생성하도록 개선.
Configuration menu - View commit details
-
Copy full SHA for 215b40b - Browse repository at this point
Copy the full SHA 215b40bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfc4c5e - Browse repository at this point
Copy the full SHA bfc4c5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4668731 - Browse repository at this point
Copy the full SHA 4668731View commit details -
* 로또들의 당첨번호 수, 보너스번호 일치여부를 기준으로 당첨등급들을 찾아서 반환한다.
Configuration menu - View commit details
-
Copy full SHA for f8ad71e - Browse repository at this point
Copy the full SHA f8ad71eView commit details -
* 검증시 0을 포함하도록 수정. * 수량을 증가량에 따라 한번에 증가시키도록 개선.
Configuration menu - View commit details
-
Copy full SHA for fbafaf0 - Browse repository at this point
Copy the full SHA fbafaf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38a2aac - Browse repository at this point
Copy the full SHA 38a2aacView commit details -
Configuration menu - View commit details
-
Copy full SHA for be9ab91 - Browse repository at this point
Copy the full SHA be9ab91View commit details -
step3: 로또(2등) 로또 OutputView 및 Main 수정
* 당첨통계 클래스 개선에 따라 출력문을 수정. * 보너스볼 당첨내용이 추가됨에 따라 메세지 포멧 분기처리하도록 개선.
Configuration menu - View commit details
-
Copy full SHA for 5b65c3f - Browse repository at this point
Copy the full SHA 5b65c3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0f3a9a - Browse repository at this point
Copy the full SHA f0f3a9aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.