🚀 2단계 - 로또(자동) #532
Open
🚀 2단계 - 로또(자동) #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyeon9mak
requested changes
Dec 5, 2022
Comment on lines
+10
to
+14
| companion object { | ||
| const val LOTTO_START_NUMBER = 1 | ||
| const val LOTTO_END_NUMBER = 45 | ||
| const val LOTTO_NUMBERS_SIZE = 6 | ||
| } |
There was a problem hiding this comment.
RandomNumberGenerator 내부에서만 사용되는 상수들이라면 private 으로 가려줄 수 있을거 같아요!
Comment on lines
+4
to
+8
| override fun generate(): List<Int> { | ||
| val range = LOTTO_START_NUMBER..LOTTO_END_NUMBER | ||
| val shuffled = range.shuffled() | ||
| return shuffled.subList(0, LOTTO_NUMBERS_SIZE).sorted() | ||
| } |
There was a problem hiding this comment.
1~45 사이 6개 난수 발생로직 깔끔하네요 👍 👍
난수가 잘 발생되는지 테스트 코드 작성이 가능할까요?
(혹시나 테스트 코드 작성에 어려움이 느껴지신다면 코멘트 남겨주세요!)
| } | ||
|
|
||
| fun validateNotBlank(string: String) { | ||
| require(!string.isBlank()) { "값이 비어 있습니다." } |
Comment on lines
+9
to
+11
| private fun String.isNumeric(): Boolean { | ||
| return this.toCharArray().all { it in '0'..'9' } | ||
| } |
Comment on lines
+7
to
+8
| const val INPUT_PAYMENT_GUIDE = "# 구입금액을 입력해주세요." | ||
| const val INPUT_LUCKY_NUMBERS_GUIDE = "# 지난 주 당첨 번호를 입력해 주세요." |
Comment on lines
+3
to
+18
| class LottoShop( | ||
| private val lottoGenerator: LottoGenerator | ||
| ) { | ||
|
|
||
| fun buy(inputPayment: Int): List<Lotto> { | ||
| val lottoCount = calculateLottoCount(inputPayment) | ||
| return lottoGenerator.generate(lottoCount) | ||
| } | ||
|
|
||
| private fun calculateLottoCount(payment: Int): Int { | ||
| return payment / LOTTO_PRICE | ||
| } | ||
|
|
||
| companion object { | ||
| private const val LOTTO_PRICE = 1000 | ||
| } |
There was a problem hiding this comment.
책임의 분리가 굉장히 훌륭하네요 😮 👍 👍
덕분에 테스트 코드도 깔끔한거 같아요!!!!
Comment on lines
+7
to
+9
| fun generate(size: Int): List<Lotto> { | ||
| return List(size) { Lotto(numberGenerator.generate()) } | ||
| } |
There was a problem hiding this comment.
정말정말 깔끔하고 좋으네요 😆
(제 취향이므로 반영 안하셔도 됩니다!) 네이밍을 통해 '1~45 사이의 로또 번호를 발급' 한다는 걸 더 티내기 위해 LottoNumberGenerator 와 같이 조금 더 적나라한 네이밍을 쓰는걸 선호합니다 😄
Comment on lines
+21
to
+22
| val luckNumbers = InputView.inputLuckyNumbers() | ||
| val statistics = lottoStatisticsService.statistics(luckNumbers, lottoList, inputPayment) |
There was a problem hiding this comment.
입력된 당첨 번호가 1~45 사이 숫자가 아닐수도 있겠네요 😄
Comment on lines
+12
to
+17
| return NumberUtil.floor(totalRate, EARING_RATE_DECIMAL_PLACE) | ||
| } | ||
|
|
||
| companion object { | ||
| private const val EARING_RATE_DECIMAL_PLACE = 2 | ||
| } |
There was a problem hiding this comment.
소숫점 둘째자리까지 '표현'한다는 것은 다른 녀석에게 더 어울리는 책임이겠죠? 😄
Comment on lines
+29
to
+34
| winLottoStatisticsResult.forEach { | ||
| val hitCount = it.winLottoPrize.hitCount | ||
| val prizeMoney = it.winLottoPrize.prizeMoney | ||
| val winLottoCount = it.winLottoCount | ||
| println("${hitCount}개 일치 (${prizeMoney}원) - ${winLottoCount}개") | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
멘토님 안녕하세요 오랜만에 PR 보내서 죄송합니다.
기능 구현
구현하면서 생각한점
Controller 에서 입력과 출력이 의존되게 구현하였으며, 결과 통계를 class에 담아서 출력하였습니다.