Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TMRS-488): retrieve categoryPath - read more slice #3977

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat(TMRS-488): retrieve categoryPath - read more slice #3977

wants to merge 5 commits into from
+25 −6

Conversation

yukiinasawa
Copy link
Contributor

@yukiinasawa yukiinasawa commented Nov 1, 2024 •
edited
Loading

Description

Updated read more slice to retrieve categoryPath as newskit api for recommended articles now returns categoryPath https://github.com/newscorp-ghfb/ncu-newskit-api/pull/1028

TMRS-488

Checklist

  • Have you done any manual testing?
  • Does it have automated tests?
  • Do you need any other PRs merged before this (if so please list)?
  • Do you need to update the README/Runbook
  • Have you checked for accessibility?

@yukiinasawa yukiinasawa requested a review from a team as a code owner November 1, 2024 10:13
@yukiinasawa yukiinasawa force-pushed the feat/TMRS-488-category-path-read-more-slice branch from 11f0c82 to fdd2a80 Compare November 1, 2024 11:12
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarisHodzicnt HarisHodzicnt HarisHodzicnt approved these changes

@douglasmik douglasmik douglasmik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yukiinasawa @HarisHodzicnt @douglasmik