Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TMD-724): comment count button experiment #3931

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

milanharia-tm
Copy link
Contributor

@milanharia-tm milanharia-tm commented Sep 2, 2024

Description

Adds a comment count button to the article share bar which links to the comment section.
Button will only display if the session storage contains the showCommentButton item (set by optimizely).

TMD-724

Checklist

  • Have you done any manual testing?
  • Does it have automated tests?
  • Do you need any other PRs merged before this (if so please list)?
  • Do you need to update the README/Runbook
  • Have you checked for accessibility?

Screenshots:

Screen.Recording.2024-09-03.at.15.45.23.mov

@milanharia-tm milanharia-tm requested a review from a team as a code owner September 2, 2024 11:41
Copy link

sonarcloud bot commented Sep 2, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 2, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 2, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 2, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 2, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 3, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 3, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 3, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 3, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 3, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 3, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@milanharia-tm
Copy link
Contributor Author

The jank you can see is caused as the iframe for the comments has not had sufficient time to load in. The only solution was to add an artificial loading state to the button to combat this but as you can see, a very long timer would be required to make the transition smooth. I'm open to any suggestions to solve this issue more elegantly

Copy link

sonarcloud bot commented Sep 3, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 10, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 10, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 10, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 10, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 10, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 12, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 16, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 16, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants