-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TMD-724): comment count button experiment #3931
base: master
Are you sure you want to change the base?
feat(TMD-724): comment count button experiment #3931
Conversation
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
The jank you can see is caused as the iframe for the comments has not had sufficient time to load in. The only solution was to add an artificial loading state to the button to combat this but as you can see, a very long timer would be required to make the transition smooth. I'm open to any suggestions to solve this issue more elegantly |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Please retry analysis of this Pull-Request directly on SonarCloud |
Quality Gate passedIssues Measures |
Description
Adds a comment count button to the article share bar which links to the comment section.
Button will only display if the session storage contains the
showCommentButton
item (set by optimizely).TMD-724
Checklist
Screenshots:
Screen.Recording.2024-09-03.at.15.45.23.mov