spike(TMRS-147): update for persisted audio POC #3823
+56
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const handleClickPlayPause = () => { | ||
| !isPlayed && setIsPlayed(true); | ||
| !showStickyPlayer && setShowStickyPlayer(true); | ||
| setIsPlaying(!isPlaying); | ||
|
|
||
| submitMsg(!isPlaying ? 'play' : 'pause'); /* send */ |
There was a problem hiding this comment.
i would suggest that we use positive check if possible rather than negative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
POC to enable persisted audio from articles on The Times.
Clicking the 'play' button will open a new tab containing a media player, and interaction with the
InArticleAudiocomponent will send data to the media player in the new tab using theBroadcastChannelAPI through thepostMessagemethod.Spike docs
https://nidigitalsolutions.jira.com/wiki/spaces/TNLDigital/pages/4855234561/Spike+TMRS-147+-+Persisted+audio+component+POC
Render PR
https://github.com/newsuk/cps-content-render/pull/7592
TMRS-147
Checklist
Screenshots (if appropriate):
Include screenshots if needed.