Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: always apply transformations on booleans #2920

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

fallwith
Copy link
Contributor

v9.14.0 introduced improved handling of boolean based configuration parameters and inadvertently broke AWS Lambda layer based functionality due to a bypassing of config transformations for booleans.

Boolean based values will now again be routed through their transformations if defined.

resolves #2919

v9.14.0 introduced improved handling of boolean based configuration
parameters and inadvertently broke AWS Lambda layer based functionality
due to a bypassing of config transformations for booleans.

Boolean based values will now again be routed through their
transformations if defined.

resolves #2919
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you! a few wording suggestions for the changelog

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
fallwith and others added 3 commits October 24, 2024 17:16
Update dev bugfix title for Lambda layer functionality restoration

Co-authored-by: Kayla Reopelle <[email protected]>
Reference the Lambda bugfix PR now that it exists

Co-authored-by: Kayla Reopelle <[email protected]>
Improve the wording for the Lambda bugfix summary

Co-authored-by: Kayla Reopelle <[email protected]>
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.81% 93%
Branch 69.75% 50%

@fallwith fallwith merged commit 24faee8 into dev Oct 25, 2024
34 checks passed
@fallwith fallwith deleted the hammet_to_latimer_to_kurosawa_and_co_to_bolzoni_and_co branch October 25, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Ruby Lambda layer stopped working on September 30th with agent version 9.14.0
3 participants