Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Include APM Labels in forwarded application logs. #2831

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jaffinito
Copy link
Member

Description

Adds labels to in-agent forwarded logs.

  • Disabled by default
  • Labels are prefixed with "tags."
  • Labels are added to each individual log entry as attributes, not as common attributes (a request from logging team)
  • No filtering of labels
  • Includes unit and integration tests

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@jaffinito jaffinito changed the title Feature/include labels logs feat:Include APM Labels in forwarded application logs. Oct 11, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.36%. Comparing base (b00edda) to head (b5fcb3c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ewRelic/Agent/Core/WireModels/LogEventWireModel.cs 60.00% 2 Missing ⚠️
...erters/LogEventWireModelCollectionJsonConverter.cs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2831      +/-   ##
==========================================
+ Coverage   81.33%   81.36%   +0.02%     
==========================================
  Files         460      460              
  Lines       29239    29259      +20     
  Branches     3231     3236       +5     
==========================================
+ Hits        23781    23806      +25     
+ Misses       4666     4660       -6     
- Partials      792      793       +1     
Flag Coverage Δ
Agent 82.27% <91.89%> (+0.03%) ⬆️
Profiler 73.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Agent/NewRelic/Agent/Core/Agent.cs 74.51% <100.00%> (+0.21%) ⬆️
...c/Agent/Core/Configuration/DefaultConfiguration.cs 89.59% <100.00%> (+0.02%) ⬆️
.../Agent/Core/Configuration/ReportedConfiguration.cs 95.74% <100.00%> (+0.01%) ⬆️
...erters/LogEventWireModelCollectionJsonConverter.cs 98.98% <95.23%> (+10.35%) ⬆️
...ewRelic/Agent/Core/WireModels/LogEventWireModel.cs 69.69% <60.00%> (+0.94%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants