Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert recent Profiler warning fixes #2663

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

chynesNR
Copy link
Member

@chynesNR chynesNR commented Aug 2, 2024

We're seeing some instability in some customer applications that seems related to these recent Profiler changes: #2545
Reverting while we investigate.

@chynesNR chynesNR marked this pull request as ready for review August 5, 2024 15:45
@chynesNR chynesNR requested a review from a team as a code owner August 5, 2024 15:45
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.73%. Comparing base (1a8a6ec) to head (8abd305).

Files Patch % Lines
...rc/Agent/NewRelic/Profiler/SignatureParser/Types.h 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2663      +/-   ##
==========================================
- Coverage   80.77%   80.73%   -0.04%     
==========================================
  Files         459      459              
  Lines       29065    29070       +5     
  Branches     3191     3191              
==========================================
- Hits        23478    23471       -7     
- Misses       4799     4810      +11     
- Partials      788      789       +1     
Flag Coverage Δ
Agent 81.72% <ø> (+0.04%) ⬆️
Profiler 71.86% <96.00%> (-0.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nt/NewRelic/Profiler/Configuration/Configuration.h 75.00% <100.00%> (-7.70%) ⬇️
...lic/Profiler/Configuration/IgnoreInstrumentation.h 100.00% <ø> (ø)
...filer/Configuration/InstrumentationConfiguration.h 93.27% <100.00%> (+0.12%) ⬆️
...elic/Profiler/Configuration/InstrumentationPoint.h 100.00% <ø> (ø)
...filer/MethodRewriter/ExceptionHandlerManipulator.h 74.28% <100.00%> (+0.37%) ⬆️
...elic/Profiler/MethodRewriter/FunctionManipulator.h 51.40% <ø> (ø)
.../NewRelic/Profiler/MethodRewriter/InstructionSet.h 55.48% <100.00%> (ø)
...ler/MethodRewriter/InstrumentFunctionManipulator.h 94.69% <100.00%> (-0.10%) ⬇️
.../NewRelic/Profiler/MethodRewriter/MethodRewriter.h 94.87% <100.00%> (+0.13%) ⬆️
...rc/Agent/NewRelic/Profiler/SignatureParser/Types.h 61.98% <75.00%> (-0.06%) ⬇️

... and 3 files with indirect coverage changes

@chynesNR chynesNR merged commit b3c9cd1 into main Aug 5, 2024
96 checks passed
@chynesNR chynesNR deleted the fix/rollback-profiler-warning-cleanup branch August 5, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants