Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Kafka node metrics to enable AWS_MSK_TOPIC entity relationships to be formed #2632

Closed
wants to merge 3 commits into from

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Jul 16, 2024

Adds two new metrics that are used to synthesize the entity relationship between AWS MSK and the APM entity:

MessageBroker/Kafka/Nodes/<host>:<port>
MessageBroker/Kafka/Nodes/<host>:<port>/<mode>/<topic>

where <host>:<port> is the Kafka server port, <mode> is either Produce or Consume and <topic> is the Kafka topic name

Updates Kafka container tests to validate the new metrics are present

@tippmar-nr tippmar-nr requested a review from a team as a code owner July 16, 2024 19:19
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.80%. Comparing base (a08b0e9) to head (e8633eb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2632      +/-   ##
==========================================
- Coverage   80.80%   80.80%   -0.01%     
==========================================
  Files         459      459              
  Lines       29064    29065       +1     
  Branches     3191     3191              
==========================================
  Hits        23486    23486              
- Misses       4788     4789       +1     
  Partials      790      790              
Flag Coverage Δ
Agent 81.71% <0.00%> (-0.01%) ⬇️
Profiler 72.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../NewRelic/Agent/Core/Utilities/ExtensionsLoader.cs 16.43% <0.00%> (-0.12%) ⬇️

Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast work!
I'm not positive collecting just the bootstrap servers is enough to form all the relationships, but we can hash that out during testing.

Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually... now that I think about it, we should probably keep these changes in a feature branch until we're sure they work

@tippmar-nr tippmar-nr changed the title chore: Add Kafka node metrics to enable AWS_MSK_TOPIC entity relationships to be formed feat: Add Kafka node metrics to enable AWS_MSK_TOPIC entity relationships to be formed Jul 17, 2024
@tippmar-nr tippmar-nr closed this Jul 17, 2024
@tippmar-nr tippmar-nr deleted the feature/kafka-node-metrics branch July 17, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants