chore: Refactor AwsSDKPipelineWrapper to encapsulate SQS handling #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chynesNR
reviewed
Jul 11, 2024
src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/AwsSdk/AwsSdkPipelineWrapper.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/sqs-instrumentation #2621 +/- ##
============================================================
Coverage 80.80% 80.80%
============================================================
Files 459 459
Lines 29064 29064
Branches 3191 3191
============================================================
Hits 23486 23486
Misses 4788 4788
Partials 790 790
Flags with carried forward coverage won't be shown. Click here to find out more. |
nrcventura
approved these changes
Jul 11, 2024
tippmar-nr
merged commit 98c2135
into
feature/sqs-instrumentation
89 of 91 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
AwsSdkPipelineWrapperto encapsulate handling for SQS messages and ensure we don't accidentally process a non-SQS request that happens to match one of the names we're looking for.