Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Dotty refactor #2618

Merged
merged 9 commits into from
Jul 11, 2024
Merged

chore: Dotty refactor #2618

merged 9 commits into from
Jul 11, 2024

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Jul 11, 2024

Significant refactoring of Dotty:

  • Disables nullable value types, as they're annoying and mostly used incorrectly
  • Introduces the use of the Nuget.Protocol package to handle queries to the Nuget API rather than direct http client calls
  • Eliminates a number of no longer needed classes
  • Adds packageInfo.json to contain the set of core tech nuget packages we want to scan rather than passing the list of packages as command-line arguments from the workflow
  • Introduces configuration options in packageInfo.json to ignore patch and/or minor version updates.
  • Updates elastic.clients.elasticsearch to ignore patch version updates, but leaves all other packages as-is (only looking for newly published, non pre-release versions).
  • Adds logic to check for ignored patch and minor versions, with appropriate logging
  • Updates the body of Github issues to be a tad more verbose
    image
  • Changes the workflow to run once a week and passes the timestamp from the previous successful run to Dotty, to use as the lower bound for searching. That ensures we don't miss anything, given the vagaries of what "today" means in different contexts.

@tippmar-nr tippmar-nr requested a review from a team as a code owner July 11, 2024 18:11
chynesNR
chynesNR previously approved these changes Jul 11, 2024
Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy!

…from then, falling back to 1 day if not found
@tippmar-nr tippmar-nr requested a review from a team July 11, 2024 19:34
@tippmar-nr tippmar-nr merged commit b24d2c9 into main Jul 11, 2024
21 checks passed
@tippmar-nr tippmar-nr deleted the chore/dotty-refactor branch July 11, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants