Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for disabling LLM monitoring at the account level. #2592

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

jaffinito
Copy link
Member

@jaffinito jaffinito commented Jul 3, 2024

Description

Add support for disabling LLM monitoring at the account level.

Includes integration tests that will require an update to the gh secrets - tests will fail till then.

Closes #2593

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@jaffinito jaffinito marked this pull request as ready for review July 8, 2024 15:04
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.88%. Comparing base (2292a51) to head (0aa7082).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2592      +/-   ##
==========================================
+ Coverage   80.87%   80.88%   +0.01%     
==========================================
  Files         458      458              
  Lines       28985    28985              
  Branches     3184     3184              
==========================================
+ Hits        23441    23445       +4     
+ Misses       4755     4752       -3     
+ Partials      789      788       -1     
Flag Coverage Δ
Agent 81.81% <100.00%> (+0.01%) ⬆️
Profiler 72.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/Agent/Core/Configuration/DefaultConfiguration.cs 89.21% <100.00%> (ø)
.../Agent/Core/Configuration/ReportedConfiguration.cs 99.10% <ø> (ø)
...ic/Agent/Core/Configuration/ServerConfiguration.cs 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@tippmar-nr tippmar-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jaffinito jaffinito merged commit c31451a into main Jul 8, 2024
99 of 100 checks passed
@jaffinito jaffinito deleted the feature/llm-account-level-disable branch July 8, 2024 17:49
kmudduluru pushed a commit that referenced this pull request Jul 16, 2024
🤖 I have created a release *beep* *boop*
---


##
[10.27.0](v10.26.0...v10.27.0)
(2024-07-15)


### New features

* Add support for disabling LLM monitoring at the account level.
([#2592](#2592))
([c31451a](c31451a))
* Instrumentation for Amazon Simple Queuing Service (AWSSDK.SQS)
([#2620](#2620))
([ac738ba](ac738ba))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support disabling AIM at account/org level
5 participants