Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Simplify logic in Elasticsearch integration tests for skipping non-async methods #2574

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

nr-ahemsath
Copy link
Member

Simplify the logic in the Elasticsearch integration tests which skips testing non-async methods in the latest versions of Elastic.Clients.Elasticsearch.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.86%. Comparing base (7a86f61) to head (e1cb078).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2574      +/-   ##
==========================================
- Coverage   80.87%   80.86%   -0.02%     
==========================================
  Files         458      458              
  Lines       28985    28985              
  Branches     3184     3184              
==========================================
- Hits        23441    23438       -3     
- Misses       4755     4757       +2     
- Partials      789      790       +1     
Flag Coverage Δ
Agent 81.78% <ø> (-0.02%) ⬇️
Profiler 72.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@nr-ahemsath nr-ahemsath merged commit 3b61279 into main Jun 26, 2024
93 checks passed
@nr-ahemsath nr-ahemsath deleted the tests/refactor-elasticsearch-syncmethodsok-logic branch June 26, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants