Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Move suppressed warnings closer to the integration test projects that generate them #2546

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Jun 12, 2024

Adds a new Directory.Build.props file at tests\Agent\IntegrationTests and takes out the warnings that were suppressed in the global Directory.Build.props file at the root of the repo.

I looked at whether it would be possible to update the code so we don't get those warnings, but it would have been a lot of work for almost zero gain. The specific warnings that are being suppressed aren't serious enough to warrant code changes, especially not in our integration test apps.

Resolve #1924

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (c018b8a) to head (250877a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2546      +/-   ##
==========================================
- Coverage   80.52%   80.49%   -0.03%     
==========================================
  Files         459      459              
  Lines       28932    28932              
  Branches     3177     3177              
==========================================
- Hits        23297    23289       -8     
- Misses       4845     4850       +5     
- Partials      790      793       +3     
Flag Coverage Δ
Agent 81.46% <ø> (-0.04%) ⬇️
Profiler 71.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@tippmar-nr tippmar-nr merged commit 8678045 into main Jun 13, 2024
93 checks passed
@tippmar-nr tippmar-nr deleted the test/suppressed-warnings-refactor branch June 13, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review the globally suppressed warnings
4 participants