chore: Update latest tested version of Microsoft.Data.SqlClient to 5.2.1 #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nr-ahemsath
requested review from
a team,
jaffinito,
nrcventura,
chynesNR,
tippmar-nr and
dotnet-agent-team-bot
auto-merge was automatically disabled
June 4, 2024 22:36
Pull request was converted to draft
chynesNR
approved these changes
Jun 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2525 +/- ##
=======================================
Coverage 80.55% 80.56%
=======================================
Files 459 459
Lines 28759 28759
Branches 3152 3152
=======================================
+ Hits 23168 23170 +2
+ Misses 4812 4811 -1
+ Partials 779 778 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2522
Edit: this also adds back testing for Microsoft.Data.SqlClient with the latest version of .NET (8.0); it was removed due to a gap in time where we had to update our testing to support 8.0 and this library didn't support 8.0 yet (it does now).