Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix lambda smoke test flicker. #2521

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

nrcventura
Copy link
Member

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

The lambda smoke tests will sometimes fail when the lambda method runs long enough to trigger a transaction trace when the test doesn't expect a transaction trace to be generated. In this PR we are flipping the logic around to ensure that a transaction trace is generated, and verify that it is included in the payload.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.55%. Comparing base (0be7ccd) to head (8e8de40).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2521      +/-   ##
==========================================
- Coverage   80.55%   80.55%   -0.01%     
==========================================
  Files         459      459              
  Lines       28759    28759              
  Branches     3152     3152              
==========================================
- Hits        23168    23166       -2     
- Misses       4812     4813       +1     
- Partials      779      780       +1     
Flag Coverage Δ
Agent 81.49% <ø> (-0.01%) ⬇️
Profiler 72.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@nrcventura nrcventura merged commit fb2434e into main Jun 3, 2024
93 checks passed
@nrcventura nrcventura deleted the fix-lambda-smoketest-flicker branch June 3, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants