Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure-monitor.mdx #19176

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

bibliobrisa
Copy link
Contributor

Adjusting assumption that collector.name is always available, as confirmed in NR-316614.

Give us some context

  • What problems does this PR solve?

Current wording in callout box suggests collector.name is always available, can confuse customers when it's not there.

  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.

    This issue confirmed in NR-316614.

Adjusting assumption that collector.name is always available, as confirmed in NR-316614.
Copy link

github-actions bot commented Nov 4, 2024

Hi @bibliobrisa 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 69c5a24
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/672c696ed7fa95000858d82d
😎 Deploy Preview https://deploy-preview-19176--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cbehera-newrelic cbehera-newrelic added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Nov 5, 2024
Copy link
Contributor

@cbehera-newrelic cbehera-newrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor spelling error

Copy link
Contributor Author

@bibliobrisa bibliobrisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@cbehera-newrelic cbehera-newrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the doc as per the suggestion

Adjusted phrasing per request.
Copy link
Contributor

@cbehera-newrelic cbehera-newrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cbehera-newrelic cbehera-newrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spelling error is still there.

change absense to absence...Also change Azure Monitor to Azure monitor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants