-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azure-monitor.mdx #19176
base: develop
Are you sure you want to change the base?
Update azure-monitor.mdx #19176
Conversation
Adjusting assumption that collector.name is always available, as confirmed in NR-316614.
Hi @bibliobrisa 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
...t/docs/infrastructure/microsoft-azure-integrations/azure-integrations-list/azure-monitor.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor spelling error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the doc as per the suggestion
Adjusted phrasing per request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spelling error is still there.
change absense to absence...Also change Azure Monitor to Azure monitor
Adjusting assumption that collector.name is always available, as confirmed in NR-316614.
Give us some context
Current wording in callout box suggests collector.name is always available, can confuse customers when it's not there.
Add any context that will help us review your changes such as testing notes,
links to related docs, screenshots, etc.
This issue confirmed in NR-316614.