Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add publish to s3 fips task #93

Merged
merged 2 commits into from
Nov 26, 2024
Merged

add publish to s3 fips task #93

merged 2 commits into from
Nov 26, 2024
+77 −0

Conversation

rajrohanyadav
Copy link
Contributor

@rajrohanyadav rajrohanyadav marked this pull request as ready for review November 25, 2024 05:54
@rajrohanyadav rajrohanyadav requested a review from a team as a code owner November 25, 2024 05:54
alvarocabanas
alvarocabanas previously approved these changes Nov 25, 2024
View reviewed changes
Copy link

@alvarocabanas alvarocabanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajrohanyadav rajrohanyadav mentioned this pull request Nov 26, 2024
Open
alvarocabanas
alvarocabanas previously approved these changes Nov 26, 2024
View reviewed changes
Copy link

@alvarocabanas alvarocabanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarocabanas
alvarocabanas approved these changes Nov 26, 2024
View reviewed changes
Copy link

@alvarocabanas alvarocabanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I hadn't seen it as well.

@rajrohanyadav rajrohanyadav merged commit 4195368 into main Nov 26, 2024
6 checks passed
@rajrohanyadav rajrohanyadav deleted the test-fips-s3-upload-schema branch November 26, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarocabanas alvarocabanas alvarocabanas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajrohanyadav @alvarocabanas